Update .NET sample#491
Merged
Merged
Conversation
- Use idiomatic formatting for C# (4 spaces, CRLF). - Avoid repetition with constants for OTLP endpoint. - Make endpoint handler methods `static`.
Avoid using .NET preview SDKs if installed.
Launch the app to the `/rolldice` endpoint to avoid an HTTP 404 when navigating to the root URL.
Update the OpenTelemetry NuGet packages to the latest stable release.
- Simplify by just publishing the app. - Add cache for NuGet packages. - Use `ASPNETCORE_HTTP_PORTS`.
Remove rogue space.
Disable .NET SDK features we don't need to speed things up.
martincostello
force-pushed
the
dotnet-formatting
branch
from
4bd1da6 to
b8578c5
Compare
zeitlinger
reviewed
May 19, 2025
Member
There was a problem hiding this comment.
great - didn't know this is possible
Arbitrarily set 180.
Move into `super-linter.env`.
zeitlinger
approved these changes
May 19, 2025
Fix sorting(?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
static./rolldiceendpoint to avoid an HTTP 404 when navigating to the root URL.ASPNETCORE_HTTP_PORTS.