remove version pin#489
Conversation
|
I'm guessing we're going to wait on merging this until the upstream issue is resolved? |
yes, we're not in a hurry since our main is clean |
|
It occurs to me, maybe it's better to leave the version pin and instead configure renovate to keep it updated? Otherwise any future change could unexpectedly break our CI with no warning. |
This is the first time for mise to break the build - but it doesn't hurt to pin - ideally with a renovate rule like docker-otel-lgtm/.github/renovate.json5 Line 63 in 7dc1248 |
|
Looks like the mise issue is fixed |
There was a problem hiding this comment.
Pull Request Overview
This pull request removes the version pin for jdx/mise-action in two GitHub workflow files, aligning with the discussion outlined in the linked discussion.
- Removed the explicit "version: 2025.5.5" configuration from the lint workflow.
- Removed the explicit "version: 2025.5.5" configuration from the acceptance tests workflow.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/lint-rest.yml | Removed the version pin to allow the action to use its default version. |
| .github/workflows/acceptance-tests.yml | Removed the version pin to allow the action to use its default version. |
Comments suppressed due to low confidence (2)
.github/workflows/lint-rest.yml:17
- Removing the version pin may result in unintentional updates; ensure that the jdx/mise-action provides a stable default version or add documentation to clarify this behavior.
- with:
.github/workflows/acceptance-tests.yml:17
- Removing the version pin may result in unintentional updates; ensure that the jdx/mise-action provides a stable default version or add documentation to clarify this behavior.
- with:
See jdx/mise#5123 (comment)