Skip to content

README tweaks#488

Merged
martincostello merged 7 commits into
mainfrom
readme-fixes
May 19, 2025
Merged

README tweaks#488
martincostello merged 7 commits into
mainfrom
readme-fixes

Conversation

@martincostello
Copy link
Copy Markdown
Member

  • Reduce need to suppress long lines using different link syntax.
  • Add missing Node.js references.
  • Use code fences for code terms.
  • Note that architecture diagram is internal-only.

- Reduce need to suppress long lines using different link syntax.
- Add missing Node.js references.
- Use code fences for code terms.
- Note that architecture diagram is internal-only.
@martincostello martincostello added the documentation Improvements or additions to documentation label May 19, 2025
- Make markdownlint and EditorConfig rules consistent.
- Re-fix EditorConfig warnings.
- Remove obsolete settings key.
Make prettier happy too.
Try to make prettier happy again.
@martincostello
Copy link
Copy Markdown
Member Author

Not being familiar with mise (or Java), I'm not sure why the JDK install is failing. It was fine on Friday when the last renovate PR was merged.

@zeitlinger
Copy link
Copy Markdown
Member

Not being familiar with mise (or Java), I'm not sure why the JDK install is failing. It was fine on Friday when the last renovate PR was merged.

me neither - I'm currently investigating

Copy link
Copy Markdown
Member

@zeitlinger zeitlinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

Comment thread CONTRIBUTING.md
```

<!-- editorconfig-checker-disable -->
<!-- markdownlint-disable MD013 -->
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a neat trick!

Comment thread README.md
An OpenTelemetry backend in a Docker image.

<!-- prettier-ignore-start -->
<!-- markdownlint-disable-next-line MD013 -->
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need annotations for prettier, markdownlint and editorconfig-checker now?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the markdownlint one to remove the squiggles I get in VS Code, but then prettier complains that there isn't a new line between the markdownlint-disable-next-line, but adding that would make the next-line not work, so it needs disabling around that block.

If there's a neater way to make all three happy for this one line I can change it (or I can just make the alt text short enough to not go over 120).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can let only one linter check the line length by telling the others to ignore the rule

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a .prettierignore to ignore Markdown sotwo of the extra lines can be removed. For the sake of just the one inline suppression I reckon that's good enough.

@martincostello martincostello marked this pull request as ready for review May 19, 2025 11:45
@martincostello martincostello enabled auto-merge (squash) May 19, 2025 11:45
@martincostello martincostello merged commit dadbb9a into main May 19, 2025
43 checks passed
@martincostello martincostello deleted the readme-fixes branch May 19, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants