Skip to content

Add trace validation to testcontainer example#424

Closed
jaydeluca wants to merge 7 commits into
grafana:mainfrom
jaydeluca:update-test
Closed

Add trace validation to testcontainer example#424
jaydeluca wants to merge 7 commits into
grafana:mainfrom
jaydeluca:update-test

Conversation

@jaydeluca
Copy link
Copy Markdown
Member

Added a basic trace validation example to the testcontainer example

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 20, 2025

CLA assistant check
All committers have signed the CLA.

});

// Get the Tempo datasource ID so we can query traces from grafana
String authHeader = "Basic " + Base64.getEncoder().encodeToString("admin:admin".getBytes(StandardCharsets.UTF_8));
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

querying tempo directly seems to be easier - similar to https://github.com/grafana/oats/blob/main/yaml/traces.go#L14 - but using java

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened a pr to update the test container to open up the port to allow querying tempo directly
testcontainers/testcontainers-java#10192

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can do a followup for both testcontainers and here to add in some logging validation next

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zeitlinger zeitlinger enabled auto-merge (squash) April 28, 2025 09:08
@zeitlinger zeitlinger disabled auto-merge April 28, 2025 09:13
@zeitlinger zeitlinger closed this Apr 28, 2025
@zeitlinger zeitlinger reopened this Apr 28, 2025
@zeitlinger
Copy link
Copy Markdown
Member

@jaydeluca just a lint needed

@zeitlinger zeitlinger enabled auto-merge (squash) April 30, 2025 09:07
zeitlinger added a commit that referenced this pull request Apr 30, 2025
replaces #424

---------

Co-authored-by: Jay DeLuca <jaydeluca4@gmail.com>
@zeitlinger zeitlinger closed this Apr 30, 2025
auto-merge was automatically disabled April 30, 2025 10:55

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants