Add mise version+sha256 pinning to CI#1070
Conversation
Pin mise version and sha256 in all workflow files for reproducibility and supply-chain security. Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
There was a problem hiding this comment.
Pull request overview
This PR strengthens CI reproducibility and supply-chain security by pinning the installed mise binary to an explicit version and sha256 in GitHub Actions workflows, aligning with the Renovate custom manager approach referenced in the PR description.
Changes:
- Add
with: versionandwith: sha256tojdx/mise-actionusage in the lint workflow. - Add
with: versionandwith: sha256tojdx/mise-actionusage in the acceptance tests workflow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/lint.yml | Pins mise version and checksum for deterministic lint runs. |
| .github/workflows/acceptance-tests.yml | Pins mise version and checksum for deterministic acceptance test runs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
.github/renovate-tracked-deps.json:54
- This PR is scoped as mise pinning, but this hunk also adds new Renovate tracking for
grafana/otel-lgtmin docker-compose files. Consider calling out these additional tracked-deps changes in the PR description (or splitting) to keep the change intent clear.
"examples/dotnet/docker-compose.yml": {
"docker-compose": [
"grafana/otel-lgtm"
]
},
.github/renovate-tracked-deps.json:251
- This adds Renovate tracking for the
pythonbase image in example Dockerfiles, which isn't mentioned in the PR description. Consider documenting this extra scope so it's clear whyrenovate-tracked-deps.jsonchanged beyond mise pinning.
"examples/obi/python.Dockerfile": {
"dockerfile": [
"python"
]
},
"examples/python/Dockerfile": {
"dockerfile": [
"python"
],
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks @Copilot — addressed 1 comment(s). Please have another look! |
Summary
versionandsha256in all workflow files for reproducibility and supply-chain securityTest plan