Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Revert "Update kv metrics to respect kv_name label" #89

Merged
Parent: Fix DNS based service discovery for memcached endpoints
merged 1 commit into from
Jun 4, 2020
Merged

Revert "Update kv metrics to respect kv_name label" #89

merged 1 commit into from
Jun 4, 2020

Conversation

@jtlisi
Copy link
Contributor

@jtlisi jtlisi commented Jun 4, 2020

Reverts #86

pracucci
pracucci approved these changes Jun 4, 2020
View reviewed changes
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We'll merge these changes again once internal rollout is done.

@jtlisi jtlisi merged commit 1c1b5d4 into master Jun 4, 2020
@jtlisi jtlisi deleted the revert-86-20200603_respect_kv_name branch June 4, 2020 15:33
simonswine pushed a commit to grafana/mimir that referenced this pull request Oct 18, 2021
@jtlisi
Merge pull request grafana/cortex-jsonnet#89 from grafana/revert-86-2…
f305c8e 
…0200603_respect_kv_name

Revert "Update kv metrics to respect kv_name label"
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@pracucci pracucci pracucci approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jtlisi @pracucci