Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Conversation

@aallawala
Copy link
Contributor

@aallawala aallawala commented Oct 18, 2021

What this PR does:
This PR adjusts the alertmanager dashboard to use the _config.job_names.alertmanager instead of the hardcoded 'alertmanager' value.
Which issue(s) this PR fixes:
Fixes #

Checklist

  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@aallawala aallawala requested a review from a team as a code owner October 18, 2021 22:06
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a comment about the default value. A part from this, LGTM. Thanks

Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pracucci pracucci merged commit b8901a9 into grafana:main Oct 22, 2021
@aallawala aallawala deleted the aja_alertmanager branch November 2, 2021 17:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants