Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Conversation

@gouthamve
Copy link
Contributor

Signed-off-by: Goutham Veeramachaneni [email protected]

@gouthamve gouthamve requested a review from a team as a code owner September 2, 2021 11:01
@gouthamve
Copy link
Contributor Author

gouthamve commented Sep 2, 2021

--- /tmp/LIVE-044939989/apps.v1.StatefulSet.cortex-dev-01.compactor
+++ /tmp/MERGED-512234544/apps.v1.StatefulSet.cortex-dev-01.compactor
@@ -38,6 +38,7 @@
         - -blocks-storage.backend=gcs
         - -blocks-storage.gcs.bucket-name=XXXXXXXXXXXXXX
         - -compactor.block-ranges=2h,12h,24h
+        - -compactor.blocks-retention-period=0
         - -compactor.cleanup-interval=15m
         - -compactor.compaction-concurrency=4
         - -compactor.compaction-interval=30m
@@ -47,6 +48,7 @@
         - -compactor.ring.store=consul
+        - -runtime-config.file=/etc/cortex/overrides.yaml
         - -schema-config-file=/etc/cortex/schema/config.yaml
         - -server.grpc.keepalive.min-time-between-pings=10s
         - -server.grpc.keepalive.ping-without-stream-allowed=true
@@ -96,6 +98,8 @@
         - mountPath: /var/secrets/google/
           name: gcs-credentials
           readOnly: true
+        - mountPath: /etc/cortex
+          name: merged-overrides
       dnsPolicy: ClusterFirst
       restartPolicy: Always
       schedulerName: default-scheduler
@@ -103,6 +107,10 @@
       terminationGracePeriodSeconds: 900
       volumes:
+      - configMap:
+          defaultMode: 420
+          name: merged-overrides
+        name: merged-overrides
       - name: gcs-credentials
         secret:
           defaultMode: 420

The diff that is produced in our dev env.

Copy link
Contributor

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this deserves changelog entry too.

Signed-off-by: Goutham Veeramachaneni <[email protected]>
@gouthamve gouthamve force-pushed the add-overrides-to-compactor branch from 4d40ca6 to baff3b4 Compare September 2, 2021 12:06
@gouthamve gouthamve merged commit 2c00155 into main Sep 2, 2021
@gouthamve gouthamve deleted the add-overrides-to-compactor branch September 2, 2021 12:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants