This repository was archived by the owner on Apr 28, 2025. It is now read-only.
Honor per_instance_label in all panels #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstibrany
approved these changes
Jan 5, 2021
pracucci
force-pushed
the
fix-instance-label
branch
from
c3704f7 to
c81e6e4
Compare
Signed-off-by: Marco Pracucci <[email protected]>
pracucci
force-pushed
the
fix-instance-label
branch
from
c81e6e4 to
5b46dc4
Compare
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Oct 18, 2021
…ce-label Honor per_instance_label in all panels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
While working on other changes in the mixin, I've realised we're not honoring everywhere the configured
per_instance_label, but we have hardcodedinstanceorpodin some panels. In this PR I'm fixing it, excluding the container metrics which are still using thepodlabel hardcoded.I manually tested all changes and should be good.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]