Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Conversation

@jtlisi
Copy link
Contributor

@jtlisi jtlisi commented Oct 11, 2020

What this PR does:

When running using a single binary the query-frontend API metrics will supersede the queriers for the same route. A separate set of latency metrics exist for the querier. This PR ensures those metrics are used by the Cortex read dashboard.

@jtlisi jtlisi requested a review from a team as a code owner October 11, 2020 19:11
Signed-off-by: Jacob Lisi <[email protected]>
Signed-off-by: Jacob Lisi <[email protected]>
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The queries and recording rules, LGTM.

I am not entirely sure where those inaccuracies are coming from in single binary mode. Does it relate to the fact that things like eventually auth are also part of the request duration in single binary mode?

@jtlisi
Copy link
Contributor Author

jtlisi commented Oct 12, 2020

@simonswine In single-binary mode we don't register the querier handler using external HTTP routes. Those routes are registered for the query-frontend instead. The querier is registered on a secondary router that we pass requests to after they are processed by the query frontend and scheduled. This router has a separate set of latency metrics prefixed cortex_querier_. The router for these metrics is used to in both single-binary and microservice mode and will have latency metrics for the querier in both cases.

@jtlisi jtlisi merged commit 26550f7 into master Oct 13, 2020
@jtlisi jtlisi deleted the 20201011_querier_api_metrics branch October 13, 2020 16:51
simonswine pushed a commit to grafana/mimir that referenced this pull request Oct 18, 2021
…uerier_api_metrics

feat: use querier specific API metrics
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants