This repository was archived by the owner on Apr 28, 2025. It is now read-only.
Renamed container_name and pod_name label names to container and pod respectively #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…respectively. Signed-off-by: Marco Pracucci <[email protected]>
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Oct 18, 2021
…tainer-and-pod-labels Renamed container_name and pod_name label names to container and pod respectively
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Kubernetes 1.16 is shipping a new version of cAdvisor which has changed label names from
pod_nametopod, and fromcontainer_nametocontainer. The expected migration path is to add Prometheus relabelling rules to injectpodandcontainerlabels before migrating to K8S 1.16, deploy the updated mixin and then upgrade to K8S 1.16, is order to not break dashboards and alerts during the whole migration process.Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]