Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Conversation

@pracucci
Copy link
Collaborator

@pracucci pracucci commented Jul 1, 2020

The Cortex PR cortexproject/cortex#2822 removes -experimental.tsdb.store-gateway-enabled: the new Cortex behaviour is having store-gateway always enabled (when using the blocks storage), which is what we were already doing in the mixin so in this PR I've just removed the flag.

This PR will be merged once Cortex PR is merged and we're ready to rollout.

@pracucci pracucci requested a review from a team as a code owner July 1, 2020 13:15
Copy link
Contributor

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@jtlisi jtlisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pracucci pracucci merged commit 3e56f78 into master Jul 28, 2020
@pracucci pracucci deleted the remove-store-gateway-enabled-flag branch July 28, 2020 12:53
simonswine pushed a commit to grafana/mimir that referenced this pull request Dec 20, 2021
…re-gateway-enabled-flag

Removed -experimental.tsdb.store-gateway-enabled flag
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants