Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release GA workflow with goreleaser #359

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

nikimanoledaki
Copy link
Contributor

@nikimanoledaki nikimanoledaki commented Nov 13, 2024

Addresses #18

  • Initialize goreleaser and its configuration
  • Add a release GA workflow to create new releases when there are new tags
  • Update docs about the release process

* Init goreleaser and its configuration
* Add a release GA workflow to create new releases when there are new tags
* Update docs about release process

* Add logs URL to alert for immediate source of information about ScaledObject
@nikimanoledaki nikimanoledaki requested a review from a team as a code owner November 13, 2024 15:55
checksum:
name_template: 'checksums.txt'
changelog:
sort: asc
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pokom we can add some rules here to exclude chore or docs if you want. My thinking was that we could leave all PR titles for now and iterate later if we want to make the release notes leaner.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed on docs and think that would be fine to add here, assuming it's a simple check. chore may be related to code changes, so I would hold off on excluding chore PR's

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added exclusions for docs and specifically chore(deps) :)

runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For security purposes, we should set the SHA instead the version: docs. Its something that we need to update in other repos 😅. Here you are an example.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL! Thanks for sharing that @spinillos. I agree, let's pin to a specific version here and we can clean up other instances in another PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know that, thank you! Changed it for the new actions, did the same for other actions that we use, and updated the docs :)

docs/contribute/releases.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Pokom Pokom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One very minor suggestion, otherwise 👍🏻

@nikimanoledaki nikimanoledaki merged commit 74b97eb into main Nov 20, 2024
2 checks passed
@nikimanoledaki nikimanoledaki deleted the nm/improve-release-notes branch November 20, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants