-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release GA workflow with goreleaser #359
Conversation
* Init goreleaser and its configuration * Add a release GA workflow to create new releases when there are new tags * Update docs about release process * Add logs URL to alert for immediate source of information about ScaledObject
checksum: | ||
name_template: 'checksums.txt' | ||
changelog: | ||
sort: asc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pokom we can add some rules here to exclude chore
or docs
if you want. My thinking was that we could leave all PR titles for now and iterate later if we want to make the release notes leaner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed on docs
and think that would be fine to add here, assuming it's a simple check. chore
may be related to code changes, so I would hold off on excluding chore
PR's
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added exclusions for docs and specifically chore(deps) :)
.github/workflows/release.yml
Outdated
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL! Thanks for sharing that @spinillos. I agree, let's pin to a specific version here and we can clean up other instances in another PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know that, thank you! Changed it for the new actions, did the same for other actions that we use, and updated the docs :)
7ce2cc3
to
e8af580
Compare
e8af580
to
5924ef8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One very minor suggestion, otherwise 👍🏻
Co-authored-by: Mark <[email protected]>
Addresses #18