Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2052 +/- ##
==========================================
+ Coverage 69.78% 73.86% +4.07%
==========================================
Files 149 149
Lines 18261 18261
==========================================
+ Hits 12744 13488 +744
+ Misses 4869 4105 -764
- Partials 648 668 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 tasks
grcevski
approved these changes
Jun 13, 2025
Contributor
grcevski
left a comment
There was a problem hiding this comment.
LGTM! Thanks, yeah passing tests should be good enough, the integration tests do a lot of OTEL specific verification.
korniltsev
added a commit
that referenced
this pull request
Jun 16, 2025
korniltsev
added a commit
that referenced
this pull request
Jun 16, 2025
korniltsev
added a commit
that referenced
this pull request
Jun 18, 2025
mariomac
added a commit
that referenced
this pull request
Jun 18, 2025
mariomac
added a commit
that referenced
this pull request
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am trying to compile alloy with the new otel ebpf profiler and need to upgrade otel to 0.128.0
I have done zero testing here in beyla itself. Just trying to make it compile.
Do you think green CI is enough or do we need to do something else?