Skip to content

chore: Ignore false positive trufflehog report#5849

Merged
kalleep merged 1 commit into
mainfrom
kalleep/ignore-false-positive-trufflehog
Mar 20, 2026
Merged

chore: Ignore false positive trufflehog report#5849
kalleep merged 1 commit into
mainfrom
kalleep/ignore-false-positive-trufflehog

Conversation

@kalleep
Copy link
Copy Markdown
Contributor

@kalleep kalleep commented Mar 20, 2026

These are reported on pr. First one was a commit hash from loki repo, don't really see the point keeping this. The second one is a fake request id used in test.

#5848 (comment)

@kalleep kalleep requested a review from a team as a code owner March 20, 2026 14:10
Copy link
Copy Markdown
Contributor

@jharvey10 jharvey10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1,10 +1,5 @@
package cloudflare

// This code is copied from Promtail (a1c1152b79547a133cc7be520a0b2e6db8b84868).
Copy link
Copy Markdown
Contributor

@jharvey10 jharvey10 Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If worth keeping, could probably shorten this to less characters to avoid trufflehog.

@kalleep kalleep enabled auto-merge (squash) March 20, 2026 14:19
@kalleep kalleep merged commit 3f320b5 into main Mar 20, 2026
50 checks passed
@kalleep kalleep deleted the kalleep/ignore-false-positive-trufflehog branch March 20, 2026 14:31
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants