chore: Use shared source structures for aws firehose #5739
Merged
Conversation
Contributor
|
💻 Deploy preview available (chore: use shared source structures for aws firehose ): |
ptodev
reviewed
Mar 10, 2026
Contributor
clayton-cornell
left a comment
There was a problem hiding this comment.
Makes sense form a docs standpoint. Data Firehose only sends HTTP requests.
Contributor
Author
Contributor
Author
|
It's a bit weird that we cannot prevent the grpc server from starting. Currently these components do not pass a port for it so a port will be selected at random. But this also means a random port will be occupied and while it's unlikely it could collide with another configured port. |
ptodev
approved these changes
Mar 11, 2026
Contributor
|
💻 Deploy preview deleted (chore: Use shared source structures for aws firehose ). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details
There is other fixes I want to do too this component but will do that in a follow up.
Issue(s) fixed by this Pull Request
Notes to the Reviewer
PR Checklist
BREAKING-CHANGE: Renamed undocumented metrics that was previously prefixed with <component_id><metric_name> to loki_source_awsfirehose<metric_name>