chore: Add test for alloy runtime to check that we start and stop components#5679
Merged
Conversation
kalleep
commented
Feb 27, 2026
Comment on lines
-304
to
-306
| for _, fe := range forEachs { | ||
| runnables = append(runnables, fe) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This is not needed we already add all foreach nodes to components
Contributor
There was a problem hiding this comment.
By this you mean, the foreach nodes are included in f.loader.Components()?
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test that verifies different component statues for alloy runtime, this is to increase confidence with upcoming scheduling changes #5613 (comment)