-
Notifications
You must be signed in to change notification settings - Fork 677
feat: Deprecate prometheus.write.queue #5509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,10 +7,12 @@ import ( | |
| "sync" | ||
|
|
||
| "github.com/go-kit/log" | ||
| "github.com/grafana/alloy/internal/component" | ||
| "github.com/grafana/alloy/internal/featuregate" | ||
| "github.com/go-kit/log/level" | ||
| promqueue "github.com/grafana/walqueue/implementations/prometheus" | ||
| "github.com/prometheus/prometheus/storage" | ||
|
|
||
| "github.com/grafana/alloy/internal/component" | ||
| "github.com/grafana/alloy/internal/featuregate" | ||
| ) | ||
|
|
||
| func init() { | ||
|
|
@@ -26,6 +28,8 @@ func init() { | |
| } | ||
|
|
||
| func NewComponent(opts component.Options, args Arguments) (*Queue, error) { | ||
| level.Warn(opts.Logger).Log("msg", "prometheus.write.queue is deprecated and will be removed in a future version. Migrate to prometheus.remote_write to prevent future errors.") | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I know we have talked about deprecation of components in general. Maybe we could add support for that during component registration. Not required for that in this pr but something we should consider at lest
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I ended up trying this out with a deprecated stability level. I might push it for feedback but I didn't feel great about it. I had to make it an "internal" stability level equivalent to Experimental which I think makes sense just felt a bit awkward. |
||
|
|
||
| s := &Queue{ | ||
| opts: opts, | ||
| args: args, | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.