Refactor Pyroscope eBPF to properly handle container IDs and executable reporters#4827
Merged
Merged
Conversation
…le reporters This change addresses the container ID handling and symbol resolution in the Pyroscope eBPF profiler by: - Replacing FileObserver with ExecutableReporter in the configuration to better reflect its purpose and enable proper cleanup with type assertions - Moving container ID to the proper layer in the event reporting flow by passing it as a parameter to createProfile instead of storing it in ExtraMeta - Simplifying the type system in tests by using upstream types (libpf.FileID and irsymcache.SourceInfo) instead of wrapper types These changes improve type safety and align the code with the OpenTelemetry eBPF profiler v0.139.0 API. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
dehaansa
added a commit
that referenced
this pull request
Nov 14, 2025
* Squashed OTel v0.139.0 * converters * update ebpfs * appease copilot * pyroscope ebpf compatibility * Update ebpf fork with otel v0.139.0 * Refactor Pyroscope eBPF to properly handle container IDs and executable reporters (#4827) This change addresses the container ID handling and symbol resolution in the Pyroscope eBPF profiler by: - Replacing FileObserver with ExecutableReporter in the configuration to better reflect its purpose and enable proper cleanup with type assertions - Moving container ID to the proper layer in the event reporting flow by passing it as a parameter to createProfile instead of storing it in ExtraMeta - Simplifying the type system in tests by using upstream types (libpf.FileID and irsymcache.SourceInfo) instead of wrapper types These changes improve type safety and align the code with the OpenTelemetry eBPF profiler v0.139.0 API. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com> * Update go.mod * Fix jaegerremotesampling test * fix a few other tests * Appease linter * linting and tests * downgrade loadbalancing exporter * Changelog entry * Update OTEL_VERSION --------- Co-authored-by: Christian Simon <simon@swine.de> Co-authored-by: Claude <noreply@anthropic.com>
4 tasks
dehaansa
added a commit
to madhub/alloy
that referenced
this pull request
Dec 10, 2025
* Squashed OTel v0.139.0 * converters * update ebpfs * appease copilot * pyroscope ebpf compatibility * Update ebpf fork with otel v0.139.0 * Refactor Pyroscope eBPF to properly handle container IDs and executable reporters (grafana#4827) This change addresses the container ID handling and symbol resolution in the Pyroscope eBPF profiler by: - Replacing FileObserver with ExecutableReporter in the configuration to better reflect its purpose and enable proper cleanup with type assertions - Moving container ID to the proper layer in the event reporting flow by passing it as a parameter to createProfile instead of storing it in ExtraMeta - Simplifying the type system in tests by using upstream types (libpf.FileID and irsymcache.SourceInfo) instead of wrapper types These changes improve type safety and align the code with the OpenTelemetry eBPF profiler v0.139.0 API. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com> * Update go.mod * Fix jaegerremotesampling test * fix a few other tests * Appease linter * linting and tests * downgrade loadbalancing exporter * Changelog entry * Update OTEL_VERSION --------- Co-authored-by: Christian Simon <simon@swine.de> Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change addresses the container ID handling and symbol resolution in the Pyroscope eBPF profiler by:
These changes improve type safety and align the code with the OpenTelemetry eBPF profiler v0.139.0 API.
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com