Add appProtocol for OpenShift #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clementduveau Looking great! LGTM! =D |
mattdurham
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
This looks reasonable to me, will defer to @petewall for final confirmation.
petewall
approved these changes
Aug 23, 2024
| @@ -29,5 +29,9 @@ spec: | |||
| port: {{ $portMap.port }} | |||
| targetPort: {{ $portMap.targetPort }} | |||
| protocol: {{ coalesce $portMap.protocol "TCP" }} | |||
| {{- if not (empty $portMap.appProtocol) }} | |||
There was a problem hiding this comment.
Could this be simplified to:
Suggested change
| {{- if not (empty $portMap.appProtocol) }} | |
| {{- if $portMap.appProtocol }} |
There was a problem hiding this comment.
Would make it easier to read. But isn't {{- if not (empty $portMap.appProtocol) }} better if you want to ensure that $portMap.appProtocol is not only present but also non-empty?
If $portMap.appProtocol is undefined or empty, the first version (empty) will prevent any unexpected issues by skipping the block, while the second version ($portMap.appProtocol) might run into problems if the variable is not properly initialized.
Chances are slim, so I am (in the end) happy with both ❤️
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
On OpenShift, to expose Alloy gRPC to receive OTLP from other ressources, by default, you need to specifiy appProtocol = h2c on the service. It actually depends on your setup but the default Ingress HAProxy requires it, so probably 80% of RedHat customers needs it.
This PR just add the appProtocol as a possibility in the values.yaml. If not set, it outputs nothing. No default value because Kubernetes uses it as a "hint", therefore it's not mandatory.
Which issue(s) this PR fixes
Fixes #1405
PR Checklist