Fix upgrade guide#4579
Merged
Merged
Conversation
marctc
reviewed
Jul 25, 2023
| The reason for the removal is a bug which caused the metrics to be incorrect if more than one instance of a traces configuration is specified. | ||
|
|
||
| Removed metrics: | ||
| - "blackbox_exporter_config_last_reload_success_timestamp_seconds" (gauge) |
Contributor
There was a problem hiding this comment.
These metrics are only removed if the integration is not used
Contributor
Author
There was a problem hiding this comment.
Even if the integration is used, would this metric show up? We are using a detached commit of the exporter, and I don't see Agent code calling the NewSafeConfig function anywhere?
Contributor
There was a problem hiding this comment.
You are right, those metrics are not relevant to the agent anymore. Good call!
marctc
approved these changes
Jul 25, 2023
ptodev
added a commit
that referenced
this pull request
Jul 25, 2023
ptodev
added a commit
that referenced
this pull request
Jul 25, 2023
dwalker-sabiogroup
pushed a commit
to dwalker-sabiogroup/agent
that referenced
this pull request
Jul 28, 2023
clayton-cornell
pushed a commit
that referenced
this pull request
Aug 14, 2023
clayton-cornell
pushed a commit
that referenced
this pull request
Aug 14, 2023
github-actions
Bot
added
the
frozen-due-to-age
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd updated the upgrade guide with a new "Main (unreleased)" section similar to the one in the changelog, but apparently there was already a 0.35 section underneath which I hadn't noticed. This will PR will add the deprecation information in the right section.