This repository was archived by the owner on Jul 28, 2026. It is now read-only.
[dev.scraping-service-scalability] Move #802 fix to kv fork - #933
Merged
rfratto merged 5 commits intoSep 22, 2021
Conversation
rfratto
commented
Sep 22, 2021
Comment on lines
-427
to
-428
| for _, key := range keys { | ||
| go func(key string) { |
Contributor
Author
There was a problem hiding this comment.
@mattdurham I decided that your approach of iterating over all the keys in a single goroutine and then flushing to a channel will likely be more performant, especially if there's thousands of keys.
mattdurham
approved these changes
Sep 22, 2021
mattdurham
left a comment
mattdurham
left a comment
Contributor
There was a problem hiding this comment.
LGTM aside from that odd test error
rfratto
merged commit Sep 22, 2021
478b33f
into
grafana-cold-storage:dev.scraping-service-scalability
7 tasks
github-actions
Bot
added
the
frozen-due-to-age
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
#802 introduced a short-term fix for #789. Now that we're making a growing amount of changes to how we interact with the KV store, it's a good opportunity to move those changes to the fork of the KV package introduced in #927.
This PR should be equivalent in performance to the Consul change, but now works for ETCD as well.
Which issue(s) this PR fixes
Notes to the Reviewer
This is the first change to the kv interface to make
Listalways return key value pairs instead of just keys.PR Checklist
Need to update the CHANGELOG to reference that the metrics changed names again.