This repository was archived by the owner on Jul 28, 2026. It is now read-only.
Fix issue with v0.0.0 builds. - #832
Merged
Merged
Conversation
# Conflicts: # CHANGELOG.md
mattdurham
marked this pull request as ready for review
August 18, 2021 13:46
rfratto
reviewed
Aug 18, 2021
| ifeq ($(BUILD_IN_CONTAINER),true) | ||
| docker build -t windows_installer ./packaging/windows | ||
| docker run --rm -t -v "${PWD}:/home" windows_installer | ||
| docker run --rm -t -v "${PWD}:/home" -e VERSION=${RELEASE_TAG} windows_installer |
Contributor
There was a problem hiding this comment.
Hmm, can't we use ${IMAGE_TAG} here?
Contributor
Author
There was a problem hiding this comment.
They are equivalent here, we could likely clean up to only use one of them.
Contributor
Author
There was a problem hiding this comment.
Though there is a situation where you can manually override each one and they would be different, not even sure if that's a valid case?
Contributor
There was a problem hiding this comment.
Yeah, I'm not sure that's something we'd want to explicitly support
rfratto
approved these changes
Aug 18, 2021
rfratto
left a comment
rfratto
left a comment
Contributor
There was a problem hiding this comment.
LGTM, up to you whether you want to try removing the reference to RELEASE_TAG when building the Windows installer
mattdurham
added a commit
that referenced
this pull request
Nov 11, 2021
github-actions
Bot
added
the
frozen-due-to-age
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
This will fix the issue with v0.0.0 versions being pushed.
Which issue(s) this PR fixes
Closes #823
Notes to the Reviewer
PR Checklist