This repository was archived by the owner on Jul 28, 2026. It is now read-only.
Reconcile when asset references change - #830
Merged
Merged
Conversation
rfratto
commented
Aug 16, 2021
| resources: | ||
| - secrets | ||
| - services | ||
| - configmaps |
Contributor
Author
There was a problem hiding this comment.
The operator's ClusterRole should've always been configured to watch for configmaps but wasn't. cc @hjet for the helm charts.
Contributor
Author
|
Testing this is blocked by #748 because the operator CRDs do not currently work against main. |
6 tasks
rfratto
force-pushed
the
watch-asset-refs
branch
2 times, most recently
from
August 19, 2021 18:54
722fc9a to
1fd10ac
Compare
Contributor
Author
|
I tested this in two scenarios:
This revealed a few final bugs in our guide, which have now been fixed. This is ready for review. |
rfratto
marked this pull request as ready for review
August 20, 2021 19:07
rfratto
commented
Aug 20, 2021
| app: grafana-agent-example | ||
| spec: | ||
| image: grafana/agent:v0.18.2 | ||
| image: grafana/agent:latest |
Contributor
Author
There was a problem hiding this comment.
I needed to temporarily make this change since v0.18.2 doesn't have any of the logs changes needed for the operator to work & pull logs. Maybe we should leave it like this?
rfratto
force-pushed
the
watch-asset-refs
branch
from
August 20, 2021 20:04
f000db9 to
b02b4f2
Compare
mattdurham
self-requested a review
August 20, 2021 20:26
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
* reconcile when used asset references change * actually use the filtered set of resources, oops * refactor deployment builder * make crds * changelog * lint error * structwalk: fix bug that caused crash * fix permissions issues
github-actions
Bot
added
the
frozen-due-to-age
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Configures the event handlers to trigger a reconcile when any referenced ConfigMap or Secret changes.
A few changes are made to facilitate doing this nicely:
On top of this change, a potential fix for #793 is included: we will default to Kubernetes' (and Prometheus Operator's) behavior w/r/t label selectors: select nothing when the selector is nil, and select everything when the selector is
{}. The exception for this continues to be namespace selectors, which will match the namespace of the parent object in the hierarchy when the namespace selector is nil.Which issue(s) this PR fixes
Fixes #655
Fixes #793 (maybe?)
Notes to the Reviewer
In draft for now. Opening for early discussion, but I need to test this beyond the unit level and consider doing a little more cleanup with the deployment builder.
PR Checklist