This repository was archived by the owner on Jul 28, 2026. It is now read-only.
Gaantunes/mongodb exporter - #826
Merged
Merged
Conversation
mattdurham
reviewed
Aug 16, 2021
| } | ||
|
|
||
| func (o output) Write(data []byte) (n int, err error) { | ||
| var ll line |
Contributor
There was a problem hiding this comment.
Would love a bit more detail/comments on this translation function.
Contributor
Author
There was a problem hiding this comment.
The credit for this one is due to @colegam, he gave me this hint to consume the exporter without needing to change it`s Log signature.
mattdurham
reviewed
Aug 16, 2021
| return c.Common | ||
| } | ||
|
|
||
| // NewIntegration creates a new elasticsearch_exporter |
Contributor
There was a problem hiding this comment.
elasticsearch -> mongodb
Contributor
Author
There was a problem hiding this comment.
woops, corrected :)
mattdurham
approved these changes
Aug 16, 2021
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
* adding mongodb exporter - draft * commiting for local tests * adding general collector * updating mongodb exporter version * removing direct connect option - always use direct connection * mongodb exporter draft * adding mongodb to example/docker-compose * restoring agent-local default config * restoring docker-compose agent default config * adjusting identation * Adjusting logging and solving lint problems * nolint on logruskit * yet some other lint problems * replacing elastic to mongodb in comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Adding mongodb exporter. For now it`s referencing a fork of the exporter, as soon as they merge a PR upstream I will reference it.
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist