This repository was archived by the owner on Jul 28, 2026. It is now read-only.
CRDs: Fix typo: EnforcedNamepsaceLabel -> EnforcedNamespaceLabel - #790
Merged
rfratto merged 4 commits intoAug 9, 2021
Merged
Conversation
controller-gen@latest now uses kubebuilder v0.6.2, which does linebreaks. Reformat to keep the diff smaller for future changes.
flokli
changed the title
Contributor
|
Thanks for working on this!
If you run |
Contributor
Author
|
I didn't use the container, but followed the instructions (from `cmd/agent-operator/DEVELOPERS.md`) - which instructs users to `go install sigs.k8s.io/controller-tools/cmd/controller-gen@latest`.
The `Dockerfile` also just uses that command.
I guess those both shouldn't use `@latest`, but explicitly pin a version (plus have cross-references in the comments on both sides).
Right now the CRDs will reformat whenever the docker image layer gets recreated, and isn't consistent with what users install manually.
|
Right now, we only asked to install `@latest`. controller-gen@v0.6.2 changed the word wrapping. Developers installing this according to `cmd/agent-operator/DEVELOPERS.md` will get CRDs formated differently than what the container image will create, and the container image will produce new outputs whenever the container layer gets recreated. Explicitly provide a version, and add cross-references on both sides to ensure this stays in sync.
Contributor
Author
|
I added a commit on top, explicitly pinning versions, and pinned There's probably few reason to stick with the older version present in the container image right now - in the current state, it'd silently self-upgrade anyways. |
flokli
commented
Aug 9, 2021
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
* operator: regenerate CRDs with controller-gen controller-gen@latest now uses kubebuilder v0.6.2, which does linebreaks. Reformat to keep the diff smaller for future changes. * operator: crds: fix typo in EnforcedNamespaceLabel * controller-gen: explicitly pin versions Right now, we only asked to install `@latest`. controller-gen@v0.6.2 changed the word wrapping. Developers installing this according to `cmd/agent-operator/DEVELOPERS.md` will get CRDs formated differently than what the container image will create, and the container image will produce new outputs whenever the container layer gets recreated. Explicitly provide a version, and add cross-references on both sides to ensure this stays in sync. * Bump build-image version Co-authored-by: Robert Fratto <robertfratto@gmail.com>
github-actions
Bot
added
the
frozen-due-to-age
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
This fixes a typo,
EnforcedNamepsaceLabel->EnforcedNamespaceLabel, and regenerates the CRDs.Notes to the Reviewer
Best reviewed on a commit-by-commit base, as the previous commit introduces a lot of diff due to wrapping.
PR Checklist