Update Postgres Exporter to v0.10.0 - #774
Conversation
| github.com/drone/envsubst v1.0.2 | ||
| github.com/fatih/structs v1.1.0 | ||
| github.com/go-kit/kit v0.10.0 | ||
| github.com/go-kit/kit v0.11.0 |
There was a problem hiding this comment.
There are a few drive-by updates in go.mod and go.sum. I'll confess to still being a bit of a n00b WRT go modules, so I think these are okay, but I am not 100% sure.
The agent still builds. and tests still pass, so I think we're good.
Part of the extensive nature of the change here is that the postgres exporter repo changed from github.com/wrouesnel/postgres_exporter to github.com/prometheus-community/postgres_exporter.
Due to my go mod inexperience, I did a go mod tidy which... May be wrong.
| DisableSettingsMetrics bool `yaml:"disable_settings_metrics,omitempty"` | ||
| AutodiscoverDatabases bool `yaml:"autodiscover_databases,omitempty"` | ||
| ExcludeDatabases []string `yaml:"exclude_databases,omitempty"` | ||
| IncludeDatabases []string `yaml:"include_databases,omitempty"` |
There was a problem hiding this comment.
I deliberately did not add the "metricPrefix" option which is new in the latest version of the exporter. My thinking is that we want to be opinionated about metric names/namespaces in the agent.
| @@ -1,5 +1,7 @@ | |||
| # Main (unreleased) | |||
|
|
|||
| - [ENHANCEMENT] Update postgres_exporter to a [branch of](https://github.com/grafana/postgres_exporter/tree/exporter-package-v0.10.0) v0.10.0 | |||
There was a problem hiding this comment.
Can you move this below the other enhancements? We try to keep the CHANGELOG sorted first by FEATURE > ENHANCEMENT > BUGFIX > CHANGE > DEPRECATION, and then by date per category.
… reflect new configuration options
* Update postgres exporter version * Update changelog with postgres exporter version bump * Preferred ordering in Changelog. Updated postgres integration docs to reflect new configuration options * Set the default metric prefix
github-actions
Bot
added
the
frozen-due-to-age
3 participants
PR Description
Bumps the version of the postgres exporter to resolve some performance issues for existing users.
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist