This repository was archived by the owner on Jul 28, 2026. It is now read-only.
Use Deployment for traces quickstart - #772
Merged
Merged
Conversation
hjet
changed the title
hjet
marked this pull request as ready for review
July 23, 2021 16:32
hjet
changed the title
rfratto
reviewed
Jul 23, 2021
rfratto
left a comment
rfratto
left a comment
Contributor
There was a problem hiding this comment.
Cool, thanks. Do we document sampling strategies anywhere in the tempo quickstart?
Contributor
Author
We don't, but I'll make a docs PR briefly addressing them and also link out to the Tempo docs |
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
* Use Deployment for traces quickstart * Add link to traces quickstart * Set HOSTNAME env var regardless of application * format, move container env to agent.libsonnet Co-authored-by: Robert Fratto <robertfratto@gmail.com>
github-actions
Bot
added
the
frozen-due-to-age
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
This PR moves quickstart deployment and configuration instructions into the Cloud docs. In addition, the trace collector Agent is rolled out as a Deployment instead of a DaemonSet by default. Tested with the Grafana demo app and Grafana Cloud.
Which issue(s) this PR fixes
Notes to the Reviewer
Broken link pending https://github.com/grafana/website/pull/5340
PR Checklist