Skip to content
This repository was archived by the owner on Jul 28, 2026. It is now read-only.

Fixing typo in the GrafanaAgents CRD - #761

Merged
rfratto merged 1 commit into
grafana-cold-storage:mainfrom
jtyr:jtyr-ga_crd_typo
Jul 22, 2021
Merged

Fixing typo in the GrafanaAgents CRD#761
rfratto merged 1 commit into
grafana-cold-storage:mainfrom
jtyr:jtyr-ga_crd_typo

Conversation

@jtyr

@jtyr jtyr commented Jul 21, 2021

Copy link
Copy Markdown
Contributor

PR Description

This PR si fixing a typo in the GrafanaAgent CRD which was probably introduced by copying description for spec.secrets to spec.configMaps.

@rfratto

rfratto commented Jul 21, 2021

Copy link
Copy Markdown
Contributor

Thanks, can you fix this in the source code? The CRDs are generated from there using make crds.

@jtyr
jtyr force-pushed the jtyr-ga_crd_typo branch from 12133ea to f581bd6 Compare July 21, 2021 23:44
@jtyr

jtyr commented Jul 21, 2021

Copy link
Copy Markdown
Contributor Author

@rfratto I have fixed it in the code.

@rfratto rfratto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rfratto
rfratto merged commit a1831c5 into grafana-cold-storage:main Jul 22, 2021
@mattdurham mattdurham mentioned this pull request Sep 7, 2021
3 tasks
mattdurham pushed a commit that referenced this pull request Nov 11, 2021
@github-actions github-actions Bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Apr 11, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants