This repository was archived by the owner on Jul 28, 2026. It is now read-only.
Operator: use reflection to discover references to secrets and configsmaps - #760
Merged
Merged
Conversation
mattdurham
approved these changes
Jul 22, 2021
mattdurham
left a comment
mattdurham
left a comment
Contributor
There was a problem hiding this comment.
Very light review but LGTM
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
…smaps (#760) * structwalk * fix lint errors
github-actions
Bot
added
the
frozen-due-to-age
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Modifies the AssetReferences code to no longer manually traverse the resource hierarchy and instead use reflection to find all secret and configmap selectors.
This allows AssetReferences to always work regardless of changes we make to the CRDs and removes the risk of forgetting to update it.
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist