This repository was archived by the owner on Jul 28, 2026. It is now read-only.
Split trace agreggation - #743
Closed
mapno wants to merge 8 commits into
Closed
Conversation
Contributor
Author
|
There are a few things still missing from the PR, mostly documentation, so I marked it as a draft. |
Contributor
Author
|
It's ready for review now |
joe-elliott
reviewed
Jul 15, 2021
| [ password: <secret> ] | ||
| [ password_file: <string> ] | ||
|
|
||
| # Configures aggregation of spans by trace. |
Contributor
There was a problem hiding this comment.
We need better docs surrounding this. Perhaps we add some docs to the Tempo site and link them here? Things that need to be mentioned:
- Increased cpu/memory usage
- How rerouting the traces works (so teams can make sure that their network topologies are compatible)
- This only makes sense if you use tail sampling or service graphs.
- Explains the relationship between this and the load balancing processor.
| # | ||
| # Longer waiting times will increase the number of traces that are correctly | ||
| # grouped. However, it will also increase the memory overhead of the processor. | ||
| group_by_trace: |
Contributor
There was a problem hiding this comment.
shouldn't the "load balancing" settings be moved out as well? maybe renamed something to suggest it's routing by trace id.
| [ wait: <duration> | default="5s" ] | ||
|
|
||
| # Configures the max amount of traces to keep in memory waiting for the duration | ||
| [ num_traces: <int> | default="1_000_000" ] |
github-actions
Bot
added
the
frozen-due-to-age
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Split trace aggregation from tail sampling, as it can be useful for other purposes too, such as service graphs or other processors that benefit from having complete traces.
The pipeline will use
groupbytraceprocessor for aggregation, except when using tail sampling, in which case grouping will be performed by the embedded aggregator in the sampling processor. It's not possible to have the tail sampling processor only sampling and leave aggregation togroupbytrace. Tail sampling has to buffer traces for at least 1s, so it's just better not to usegroupbytracein that case for simplicity and performance.PR Checklist