Skip to content
This repository was archived by the owner on Jul 28, 2026. It is now read-only.

Update cross reference syntax in Agent static mode documentation (#4814) - #4903

Merged
clayton-cornell merged 1 commit into
release-v0.35from
backport-4814-to-release-v0.35
Aug 23, 2023
Merged

clayton-cornell merged 1 commit into
release-v0.35from
backport-4814-to-release-v0.35

Conversation

@clayton-cornell

Copy link
Copy Markdown
Contributor
  • First pass at updating references

  • Remove note admonition

  • Adjust ref syntax

  • Trying different syntax

  • Restory syntax to documented style

  • Ensure that Hugo knows the documentation is versioned

Allows interpoloation of the <GRAFANA VERSION> variable used in the docs/reference shortcode.

Signed-off-by: Jack Baldry jack.baldry@grafana.com

  • Use more appropriate version variable

Signed-off-by: Jack Baldry jack.baldry@grafana.com

  • Update cross references in setup

  • Update install cross references

  • Update cross refs in api and operations

  • First pass at updating conf refs

  • Fix remaining cross refs

  • Convert to relative links for cloud

  • Fix URL sytnax


Signed-off-by: Jack Baldry jack.baldry@grafana.com
Co-authored-by: Jack Baldry jack.baldry@grafana.com
(cherry picked from commit 0cd4d26)

PR Description

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

* First pass at updating references

* Remove note admonition

* Adjust ref syntax

* Trying different syntax

* Restory syntax to documented style

* Ensure that Hugo knows the documentation is versioned

Allows interpoloation of the `<GRAFANA VERSION>` variable used in the `docs/reference` shortcode.

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

* Use more appropriate version variable

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

* Update cross references in setup

* Update install cross references

* Update cross refs in api and operations

* First pass at updating conf refs

* Fix remaining cross refs

* Convert to relative links for cloud

* Fix URL sytnax

---------

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Co-authored-by: Jack Baldry <jack.baldry@grafana.com>
(cherry picked from commit 0cd4d26)
@clayton-cornell clayton-cornell added type/docs Docs Squad label across all Grafana Labs repos backport labels Aug 23, 2023
@clayton-cornell
clayton-cornell requested a review from a team as a code owner August 23, 2023 14:46
endpoint.

Static mode is [configured][] with a YAML file.
Static mode is [configured][configure] with a YAML file.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this work? What is shown to the user?

@clayton-cornell clayton-cornell Aug 23, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this work? What is shown to the user?

It's in the format [link text][label]. The link text is what's shown to the reader, and the label is what Hugo uses to connect the link text with a URL. So, you can use different link text throughout the topic if you reuse the link destination (defined by the label). This syntax was always possible with the relref shortcode syntax and is reused for docs/reference shortcode.

In this specific case, the reader sees Static mode is configured with a YAML file. and the link under configured is defined on line 89 of this file as [configure]: "/docs/agent/ -> /docs/agent/<AGENT VERSION>/static/configuration" Line 90 defines the link for use in Grafana Cloud docs.

https://grafana.com/docs/writers-toolkit/write/shortcodes/#docsreference-shortcode

@mattdurham mattdurham left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clayton-cornell
clayton-cornell merged commit e384456 into release-v0.35 Aug 23, 2023
@clayton-cornell
clayton-cornell deleted the backport-4814-to-release-v0.35 branch August 23, 2023 20:21
@github-actions github-actions Bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 22, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants