This repository was archived by the owner on Jul 28, 2026. It is now read-only.
add sigv4 install script, fix bug - #334
Merged
Merged
Conversation
Also fixes bug where the deployment scrape config was included with host filtering enabled, where the inverse should've been true.
rfratto
commented
Jan 19, 2021
Comment on lines
+73
to
+75
| $._config.kubernetes_scrape_configs | ||
| else | ||
| $._config.kubernetes_scrape_configs, | ||
| $._config.kubernetes_scrape_configs + $._config.deployment_scrape_configs, |
Contributor
Author
There was a problem hiding this comment.
This was the bug. When host filtering is enabled, it shouldn't include the deployment scrape configs.
rfratto
commented
Jan 19, 2021
| @@ -0,0 +1,357 @@ | |||
| apiVersion: v1 | |||
Contributor
Author
There was a problem hiding this comment.
This file is generated, don't need to review it directly
rfratto
commented
Jan 19, 2021
| tls_config: | ||
| ca_file: /var/run/secrets/kubernetes.io/serviceaccount/ca.crt | ||
| insecure_skip_verify: false | ||
| - bearer_token_file: /var/run/secrets/kubernetes.io/serviceaccount/token |
Contributor
Author
There was a problem hiding this comment.
This file is generated, don't need to review it directly
mattdurham
approved these changes
Jan 19, 2021
56quarters
approved these changes
Jan 19, 2021
3 tasks
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
Also fixes bug where the deployment scrape config was included with host filtering enabled, where the inverse should've been true.
github-actions
Bot
added
the
frozen-due-to-age
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Adds a sigv4-specific install script.
Also fixes bug where the deployment scrape config was included with host filtering enabled, where the inverse should've been true. (cc @hjet, this fixes the duplicate default/kubernetes job)
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist