This repository was archived by the owner on Jul 28, 2026. It is now read-only.
Resolve K8s API server IP using DNS - #330
Merged
Merged
Conversation
|
|
rfratto
approved these changes
Jan 14, 2021
rfratto
left a comment
rfratto
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks! I added the server_name field to the Jsonnet which the YAML is generated from. Can you sign the CLA before I merge?
Contributor
Author
|
Ah awesome thanks! Total Jsonnet noob but will make changes there from now on. One remaining issue is that I think with the current config we're double scraping the API server (both the deployment and daemonset agents have the |
Contributor
|
I'd prefer that to be another PR :) |
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
* Explicitly specify API server Service name so DNS resolves to IP matching cert. * Update changelog * add server_name to jsonnet Co-authored-by: Robert Fratto <robertfratto@gmail.com>
github-actions
Bot
added
the
frozen-due-to-age
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Agent scrapes the K8s API server using Prometheus K8s service discovery. If using the "endpoints" role (as is currently done in the manifest), the TLS
server_nameparameter must be set to the K8s API server Service name (kubernetesby default), which resolves to the ClusterIP address contained in the X.509 client cert used for authentication. If omitted, Prom service discovery will use the Endpoints object IP address, which is not referenced in the cert and will cause an error. Tested on DigitalOcean Kubernetes. This may be provider-specific? To investigate on GCP, etc.Which issue(s) this PR fixes
Notes to the Reviewer
See Slack thread.
PR Checklist