This repository was archived by the owner on Jul 28, 2026. It is now read-only.
don't mount /var/log as readonly - #314
Merged
rfratto merged 2 commits intoJan 8, 2021
Merged
Conversation
56quarters
approved these changes
Jan 7, 2021
56quarters
left a comment
56quarters
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I assume the error was logged in some form already?
Contributor
Author
Yeah, Promtail should log it as failed to write positions file (I'm waiting to merge this, we might end up saving the positions file to |
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
* don't mount /var/log as readonly * update phrasing in changelog to explain what the issue was
github-actions
Bot
added
the
frozen-due-to-age
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
The
/var/logfolder is used by default for storing the last read file offset. We were previously mounting this path as readonly. Writing the positions.yaml to this folder helps the Agent recover from a crash and not resend logs that were already sent to Loki.This change reflects what the official Promtail configs do.
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist