This repository was archived by the owner on Jul 28, 2026. It is now read-only.
Fixing issue 206 - Listen Address Mapping - #308
Merged
mattdurham merged 8 commits intoJan 6, 2021
Conversation
Added mapping for listen address so that it propagates correctly and is honored by the http server.
|
|
mattdurham
marked this pull request as ready for review
January 6, 2021 15:53
rfratto
approved these changes
Jan 6, 2021
rfratto
left a comment
rfratto
left a comment
Contributor
There was a problem hiding this comment.
Nice, thanks for fixing this! After you address my comments, feel free to merge :)
3 tasks
mattdurham
added a commit
that referenced
this pull request
Nov 11, 2021
* Fixing issue 206 Added mapping for listen address so that it propagates correctly and is honored by the http server. * Added changelog doc * Added additional comments on changelog * Clean up formatting * Changed host to pointer and updated tests to support that * Cleaned up spacing
github-actions
Bot
added
the
frozen-due-to-age
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added mapping for listen address so that it propagates correctly and is honored by the http server.
PR Description
Added assignment of the host address and test where port was being used.
Which issue(s) this PR fixes
206
Notes to the Reviewer
PR Checklist