This repository was archived by the owner on Jul 28, 2026. It is now read-only.
Getting started guide: correct the config file path - #299
Merged
rfratto merged 1 commit intoDec 29, 2020
Conversation
|
|
rfratto
approved these changes
Dec 29, 2020
rfratto
left a comment
rfratto
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing this! /etc/agent-config/agent.yaml is used in a bunch of other places correctly (e.g., where -config.file /etc/agent-config/agent.yaml is also passed explicitly as an arg), so it seems like a poorly handled copy and paste is responsible for this one.
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
github-actions
Bot
added
the
frozen-due-to-age
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
The Dockerfile's CMD statement clearly expects the config file to be present at
/etc/agent/agent.yamllocation but following instructions in Getting Started guide gets potential user nowhere with errorerror loading config file /etc/agent/agent.yaml: error reading config file: open /etc/agent/agent.yaml: no such file or directory.Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist