Config file environment expansion - #281
Conversation
|
Thanks for working on this! Following up from our discussion in #280:
I'd prefer it to work this way. The Loki implementation of this (including the use of One other thing: please update the CHANGELOG and give yourself credit for working on this :) |
|
Implementation is done and CHANGELOG is updated :) Looking forward to your review. |
rfratto
left a comment
There was a problem hiding this comment.
One small nit but this looks great! Do you mind if I add a commit for documenting this in the configuration reference? You're also free to take a crack at it if you want.
Co-authored-by: Robert Fratto <robertfratto@gmail.com>
|
No, feel free to add the docs! |
|
Looks like the permission for me to add commits is disabled. I'll just merge this now and follow up with docs. Thanks again! |
* Added config environment expansion * Implemented optional env-var config substitution using CLI flag * Update pkg/config/config.go Co-authored-by: Robert Fratto <robertfratto@gmail.com> Co-authored-by: Robert Fratto <robertfratto@gmail.com>
PR Description
It would be a great feature to expand the configuration file with environment variables like described in issue #280.
Which issue(s) this PR fixes
Fixes #280 Expand config file with environment variables
Notes to the Reviewer
PR Checklist