This repository was archived by the owner on Jul 28, 2026. It is now read-only.
Override Promtail User-Agent header - #270
Merged
Merged
Conversation
rfratto
force-pushed
the
loki-user-agent
branch
from
December 7, 2020 13:35
cc0e3c2 to
284dba5
Compare
This avoids the same problem that Loki originally had and allows downstream importers that use prometheus/common/version to import the loki package without it overwriting their build info.
dafydd-t
approved these changes
Dec 7, 2020
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
* override Loki User-Agent header Fixes #188 * update CHANGELOG * revert hacky workaround, no longer needed now that fix in loki is merged * use prometheus version for setting user-agent header This avoids the same problem that Loki originally had and allows downstream importers that use prometheus/common/version to import the loki package without it overwriting their build info.
github-actions
Bot
added
the
frozen-due-to-age
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #188
PR Description
Which issue(s) this PR fixes
Notes to the Reviewer
The hack that forced the Agent after Loki in the dependency graph is no longer needed; my PR to Loki (which has been vendored for a while) fixed the issue that required it.
PR Checklist