Skip to content
This repository was archived by the owner on Jul 28, 2026. It is now read-only.

update promtail to fix relative symlinks - #1826

Merged
rfratto merged 1 commit into
grafana-cold-storage:mainfrom
mukerjee:fix-relative-symlink
Jun 27, 2022
Merged

update promtail to fix relative symlinks#1826
rfratto merged 1 commit into
grafana-cold-storage:mainfrom
mukerjee:fix-relative-symlink

Conversation

@mukerjee

@mukerjee mukerjee commented Jun 24, 2022

Copy link
Copy Markdown
Contributor

PR Description

Promtail has had a longstanding issue with relative symlinks (see
grafana/loki#1240 , grafana/loki#4905 , and grafana-cold-storage/tail#11 ). This was fixed
in grafana-cold-storage/tail#12 but was never pulled into agent. In this commit we update
grafana/tail to pull in this fix.

Which issue(s) this PR fixes

grafana/loki#1240 and grafana/loki#4905

Notes to the Reviewer

This commit was created by updating the commit hash for tail and then running
go mod tidy.

PR Checklist

  • CHANGELOG updated
  • Documentation added
  • Tests updated

Promtail has had a longstanding issue with relative symlinks (see
grafana/loki/grafana-cold-storage#1240 , grafana/loki/grafana-cold-storage#4905 , and grafana/tail/grafana-cold-storage#11 ). This was fixed
in grafana/tail/grafana-cold-storage#12 but was never pulled into agent. In this commit we update
grafana/tail to pull in this fix.

This commit was created by updating the commit hash for tail and then running
`go mod tidy`.

@rfratto rfratto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@rfratto
rfratto merged commit 96d479e into grafana-cold-storage:main Jun 27, 2022
@mukerjee
mukerjee deleted the fix-relative-symlink branch June 27, 2022 18:58
@github-actions github-actions Bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Mar 26, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants