This repository was archived by the owner on Jul 28, 2026. It is now read-only.
pkg/operator/config: don't set non-existent username_file field - #1612
Merged
Merged
Conversation
PR grafana-cold-storage#1441 introduced a change to use password_file for basic auth, but accidentally also generated a username_file field which doesn't exist.
rfratto
added a commit
to rfratto/agent
that referenced
this pull request
Apr 14, 2022
…ana-cold-storage#1612) PR grafana-cold-storage#1441 introduced a change to use password_file for basic auth, but accidentally also generated a username_file field which doesn't exist. (cherry picked from commit 378ffed)
Merged
rfratto
added a commit
that referenced
this pull request
Apr 14, 2022
* Set up the default logger parameters (#1611) * Set up the default logger parameters Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com> * Set up the default logger parameters vol.2 Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com> (cherry picked from commit 3b8d8b9) * pkg/operator/config: don't set non-existent username_file field (#1612) PR #1441 introduced a change to use password_file for basic auth, but accidentally also generated a username_file field which doesn't exist. (cherry picked from commit 378ffed) * Bump GitHub exporter version (#1589) * bump version of github-exporter This bumps the version of github-exporter to the latest upstream commit, fixing numerous bugs since the latest development release. Closes #1588. * add changelog entry Also add a retroactive changelog entry for #1584 (cherry picked from commit 61e8f37) * udpate import order in agentctl main.go (#1584) (cherry picked from commit 78aa623) * Embed time zone data for logs package (#1594) (cherry picked from commit 2c53aff) * changelog: add changelog entry for agentctl version info bugfix * Set `Content-Type` as `application/json` to JSON endpoints (#1596) * Set json content-type to JSON endpoints * Update CHANGELOG (cherry picked from commit cff7cb4) * prepare for 0.24.1 release Co-authored-by: Paschalis Tsilias <tpaschalis@users.noreply.github.com> Co-authored-by: Robert Lankford <robert.lankford@grafana.com> Co-authored-by: Marc Tudurí <marctc@protonmail.com>
github-actions
Bot
added
the
frozen-due-to-age
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
PR #1441 introduced a change to use password_file for basic auth, but
accidentally also generated a username_file field which doesn't exist.
This is a partial revert of #1441, keeping only the password_file change.
Which issue(s) this PR fixes
Fixes #1601
Notes to the Reviewer
PR Checklist