Skip to content
This repository was archived by the owner on Jul 28, 2026. It is now read-only.

tools/crow: make sure that default settings are applied to crow - #1480

Merged
rfratto merged 5 commits into
grafana-cold-storage:mainfrom
rfratto:fix-crow-defaults
Mar 10, 2022
Merged

tools/crow: make sure that default settings are applied to crow#1480
rfratto merged 5 commits into
grafana-cold-storage:mainfrom
rfratto:fix-crow-defaults

Conversation

@rfratto

@rfratto rfratto commented Mar 10, 2022

Copy link
Copy Markdown
Contributor

Follow up from #1476

@rfratto
rfratto requested a review from mattdurham March 10, 2022 18:41
Comment thread tools/crow/main.go
Comment on lines +31 to +32
serverCfg = server.DefaultConfig
crowCfg = crow.DefaultConfig

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the main fix, but I'm also updating the jsonnet to be defensive

@rfratto rfratto changed the title crow: make sure that default settings are applied to crow tools/crow: make sure that default settings are applied to crow Mar 10, 2022

@mattdurham mattdurham left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rfratto
rfratto enabled auto-merge (squash) March 10, 2022 19:15
@rfratto
rfratto merged commit be0b5a9 into grafana-cold-storage:main Mar 10, 2022
@rfratto
rfratto deleted the fix-crow-defaults branch March 10, 2022 19:38
@github-actions github-actions Bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Apr 3, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants