Skip to content
This repository was archived by the owner on Jul 28, 2026. It is now read-only.

Fix permissions for WAL data directory - #1474

Merged
rfratto merged 1 commit into
grafana-cold-storage:mainfrom
rfratto:deb-rpm-wal-permissions
Mar 9, 2022
Merged

rfratto merged 1 commit into
grafana-cold-storage:mainfrom
rfratto:deb-rpm-wal-permissions

Conversation

@rfratto

@rfratto rfratto commented Mar 8, 2022

Copy link
Copy Markdown
Contributor

Fixes #1471

@rfratto
rfratto requested a review from tpaschalis March 8, 2022 21:17
@rfratto

rfratto commented Mar 8, 2022

Copy link
Copy Markdown
Contributor Author

(Do we have an easy way of testing this change? I'm pretty sure this will do it but instructions for manual testing should be something we document somewhere.)

cc @jdbaldry if you remember how to test these

@jdbaldry

jdbaldry commented Mar 8, 2022

Copy link
Copy Markdown
Contributor

There's a test-packages target in the Makefile (https://github.com/grafana/agent/blob/main/Makefile#L477-L479). I'm not sure how much the underlying script would have degraded though so it may need some TLC. Let me know if you need someone to take a look at that and I'll put it on my list for tomorrow.

@rfratto

rfratto commented Mar 8, 2022

Copy link
Copy Markdown
Contributor Author

Thanks Jack! I can look into it, no need for you to spend time on it.

Also, it's late for you, stop looking at Github :)

@tpaschalis tpaschalis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simple enough! ^^

@rfratto
rfratto merged commit 82a0edc into grafana-cold-storage:main Mar 9, 2022
@rfratto
rfratto deleted the deb-rpm-wal-permissions branch March 9, 2022 14:25
@github-actions github-actions Bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Apr 3, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect permissions for /var/lib/grafana-agent directory in RPM install

3 participants