Skip to content
This repository was archived by the owner on Jul 28, 2026. It is now read-only.

Update agent-traces with updated OTLP port 4317 - #1465

Closed
1udde wants to merge 3 commits into
grafana-cold-storage:mainfrom
1udde:patch-1
Closed

Update agent-traces with updated OTLP port 4317#1465
1udde wants to merge 3 commits into
grafana-cold-storage:mainfrom
1udde:patch-1

Conversation

@1udde

@1udde 1udde commented Mar 4, 2022

Copy link
Copy Markdown

PR Description

OTLP gRPC receivers listen at port 4317 by default, instead of at port 55680.
This goes in line with OTLP legacy port deprecation.

This change is in line with PR #1464

Which issue(s) this PR fixes

Grafana Agent does not receive any spans if applications push to port 55680 in later versions due to port change.

Notes to the Reviewer

PR Checklist

  • CHANGELOG updated
  • Documentation added
  • Tests updated

OTLP gRPC receivers listen at port `4317` by default, instead of at port `55680`.
This goes in line with OTLP legacy port deprecation.

This change is in line with PR grafana-cold-storage#1464
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mapno mapno left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, these manifests are actually built from templates (see docs). To actually change this, we should change the traces jsonnet template and run make examples-kubernetes.

Thanks!

@mapno

mapno commented Mar 30, 2022

Copy link
Copy Markdown
Contributor

Hey! Sorry this PR slipped through the cracks. This PR addressed the same issue #1537.

Thanks anyway! :)

@mapno mapno closed this Mar 30, 2022
@github-actions github-actions Bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Mar 31, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants