This repository was archived by the owner on Jul 28, 2026. It is now read-only.
remove duplicate suffix from calls_total spanmetric - #1449
Merged
mapno merged 3 commits intoMar 3, 2022
Conversation
mapno
approved these changes
Mar 3, 2022
mapno
left a comment
mapno
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for the contribution again!
mapno
suggested changes
Mar 3, 2022
mapno
left a comment
mapno
left a comment
Contributor
There was a problem hiding this comment.
Sorry, missed a change that I believe should be reverted.
github-actions
Bot
added
the
frozen-due-to-age
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Because of an upstream fix, the metric have duplicate
_totalsuffixes and comes out astraces_spanmetrics_calls_total_totalNotes to the Reviewer
I wanted to write a test for this as well, but didn't find a way of doing it, since the name is being created in the processor upstream. If you have any suggestions on a test, please let me know.
PR Checklist