Parse const_labels correctly in exporter - #1440
Conversation
|
Test failed with I think that is unrelated, I can run all the tests locally |
mapno
left a comment
There was a problem hiding this comment.
Hi! Thanks for addressing this issue, it's an awful bug.
It'd be great if we add const_labels to the test. Please, add an entry to the CHANGELOG :)
Co-authored-by: Mario <mariorvinas@gmail.com>
9574b7d to
fec3832
Compare
I added a new test that sets the spanmetrics section and creates a traces collector. Would you rather that I add it to the
Done! |
There was a problem hiding this comment.
I added a new test that sets the spanmetrics section and creates a traces collector.
Nice! Looks good to me. Thanks!
Would you rather that I add it to the TestTraces-test?
That's fine by me. I think ideally the test should be in config_test.go, but it's fine where it is as long as it's tested. Up to you!
Thanks for the PR and addressing the comments! :)
PR Description
Config field
const_labelshave different types in the remotewriterexporter than it has in the main config type. This causes an error when starting the agent:With this example config:
Notes to the Reviewer
The previous implementation also had a bug in the mapstructure field, where both value and name where named
name.PR Checklist