Skip to content
This repository was archived by the owner on Jul 28, 2026. It is now read-only.

RFC-0001: Add status to RFC #1391

Merged
rfratto merged 2 commits into from
Feb 23, 2022
Merged

RFC-0001: Add status to RFC #1391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f967a5
rfc-0001: add rules for when RFC PRs should be merged
rfratto Feb 17, 2022
5c00f27
use status field instead of merge to indicating state
rfratto Feb 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/rfcs/0000-template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@
* Date: YYYY-MM-DD
* Author: Full Name (@github_username)
* PR: [grafana/agent#XXXX](https://github.com/grafana/agent/pull/XXXX)
* Status: Draft
19 changes: 19 additions & 0 deletions docs/rfcs/0001-designing-in-the-open.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
* Date: 2021-11-02
* Author: Robert Fratto (@rfratto)
* PR: [grafana/agent#1055](https://github.com/grafana/agent/pull/1055)
* Status: Implemented

## Summary

Expand Down Expand Up @@ -77,6 +78,7 @@ RFC PR proposals must at least:
* The date the proposal was written
* The list of authors, with their names and GitHub usernames
* The PR where the proposal was posted
* The status of the proposal

`0000-template.md` contains a template to use for writing proposals that
conforms to these rules.
Expand All @@ -96,6 +98,23 @@ example sections in the RFC may be:
* Open Questions: What questions still need to be answered?
* Prior Art: What was this proposal based on, if anything?

#### RFC Status

The "Status" field of an RFC must be one of the following:

* Draft: This RFC is a work-in-progress and may change
* Implemented: Relevant code for this RFC has been merged to the main branch
* Deprecated: This RFC is no longer relevant to the current state of the
project

RFCs may be merged in Draft state as work on them progresses. The _Draft_ state
is intended to signal to readers that an RFC is in flux. Once all relevant code
for an RFC is merged to main, the RFC may move to the _Implemented_ status.
RFCs without code, such as this RFC, may immediately be set as Implemented.

If, for any reason, an RFC becomes no longer relevant (deprecated by another
RFC, code removed, etc.), its status should move to Deprecated.

#### RFC Review

RFCs should be opened as a PR to grafana/agent, ideally prefixed in the PR
Expand Down