This repository was archived by the owner on Jul 28, 2026. It is now read-only.
Conversation
(also use a consistent base image tag instead of latest)
This commit introduces CRDs for integrations: * MetricsIntegration is a child of GrafanaAgent and is used to specify a running metrics-based integration. * IntegrationMonitor is a child of MetricsInstance and is used to specify which MetricsIntegrations should be scraped for metrics. The CRDs have been added to the resource hierarchy and will automatically be discovered when reconciling a GrafanaAgent resource. While the resources are discovered, this commit does *not* run integrations or collect metrics from them. As a part of this change, the old config.Deployment type has been moved to pkg/operator/apis/monitoring/v1alpha1. This allows it to take advantage of the DeepCopy function generation, a method which was previously manually maintained.
rfratto
force-pushed
the
operator-integration-crds
branch
from
January 20, 2022 00:11
a3b6658 to
1f97650
Compare
rlankfo
reviewed
Jan 20, 2022
rlankfo
approved these changes
Jan 24, 2022
3 tasks
github-actions
Bot
added
the
frozen-due-to-age
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces CRDs for integrations:
MetricsIntegration is a child of GrafanaAgent and is used to specify a
running metrics-based integration.
IntegrationMonitor is a child of MetricsInstance and is used to
specify which MetricsIntegrations should be scraped for metrics.
The CRDs have been added to the resource hierarchy and will
automatically be discovered when reconciling a GrafanaAgent resource.
While the resources are discovered, this commit does not run
integrations or collect metrics from them.
As a part of this change, the old config.Deployment type has been moved
to pkg/operator/apis/monitoring/v1alpha1. This allows it to take
advantage of the DeepCopy function generation, a method which was
previously manually maintained.