This repository was archived by the owner on Jul 28, 2026. It is now read-only.
Conversation
Given grafana-cold-storage#1198 and the intent that we will have integrations beyond metrics, it feels like a good move to rename IntegrationsInstance and IntegrationMonitor to MetricsIntegrationsInstance and MetricsIntegrationMonitor respectively. This will allow us to configure fields that we know are commonly available on all metrics integrations but not necessarily on non-metrics integrations. The old "mode" field has been changed to "type", where a type is either daemonset (run on every node), singleton (run once per GrafanaAgent deployment) or normal (run any number of times per GrafanaAgent deployment). This aligns with the functionality present in grafana-cold-storage#1198. "daemonset" and "singleton" both refer to integrations that can only be defined once per Grafana Agent. Having both at the operator level makes sense; statsd_exporter can only be defined once per agent, but you wouldn't necessarily want it running on every node. Given that, it makes sense to distinguish between the two single-instance integration types specifically for Kubernetes.
Contributor
Author
|
This work has been superseded by another dev branch. |
github-actions
Bot
added
the
frozen-due-to-age
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given #1198 and the intent that we will have more types of integrations that aren't just for metrics, it feels like a good move to rename IntegrationsInstance and IntegrationMonitor to MetricsIntegrationsInstance and MetricsIntegrationMonitor respectively.
This change will allow us to configure fields that we know are commonly available on all metrics integrations (e.g.,,
instanceorautoscrape) but not necessarily available on integrations of different types.Additionally, the old "mode" field has been changed to "type", where a type is either
daemonset(run on every node),singleton(run once per GrafanaAgent deployment) ornormal(run any number of times per GrafanaAgent deployment). This aligns with the multiplexing functionality present in #1198."daemonset" and "singleton" both refer to integrations that can only be defined once per Grafana Agent. This is a concept unique to the operator; while node_exporter and statsd_exporter are both single-instance integrations, you would definitely want node_exporter to run on every node, but that's not necessarily also true of statsd_exporter.
This PR is some light prep work while #1198 is being reviewed. A new design doc supplanting the original one in #883 will follow, since #1998 will changes the implementation details and I've learned some lessons during my prototyping that should be written down.