Skip to content
This repository was archived by the owner on Jul 28, 2026. It is now read-only.

Tracing pipeline dashboard and alerts - #1166

Merged
mapno merged 11 commits into
grafana-cold-storage:mainfrom
mapno:tracing-mixin
Dec 17, 2021
Merged

mapno merged 11 commits into
grafana-cold-storage:mainfrom
mapno:tracing-mixin

Conversation

@mapno

@mapno mapno commented Dec 14, 2021

Copy link
Copy Markdown
Contributor

PR Description

Adds new Agent Tracing Pipeline jsonnet dashboard and prometheus alerts to production mixin.

Other changes:

  • Updates jsonnet libraries
  • Linted jsonnet

image

PR Checklist

  • CHANGELOG updated
  • Documentation added
  • Tests updated

@mapno
mapno marked this pull request as ready for review December 14, 2021 15:27
@mapno mapno changed the title Tracing pipeline dashboard Tracing pipeline dashboard and alerts Dec 14, 2021

@rfratto rfratto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from jsonnet perspective, but I didn't validate the dashboards or alerts since you're the expert there

Comment thread example/k3d/smoke/main.jsonnet
Comment thread production/grafana-agent-mixin/alerts.libsonnet Outdated
Comment thread production/grafana-agent-mixin/dashboards.libsonnet

@annanay25 annanay25 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on adding the agent tracing mixin!

Question: Wondering if some of the info on the panels is redundant. Do we need individual panels for Received, Accepted and Rejected spans? Similarly for exported spans.

@mapno

mapno commented Dec 15, 2021

Copy link
Copy Markdown
Contributor Author

Question: Wondering if some of the info on the panels is redundant. Do we need individual panels for Received, Accepted and Rejected spans? Similarly for exported spans.

Sure, it's kind of the same information but displayed in different ways. The panels in the first row give per-pod details, while the other one give a more general view. Does that make sense?

@annanay25

Copy link
Copy Markdown
Contributor

Ok, might be good to add a legend {{pod}} on the first row panels.

@mapno

mapno commented Dec 15, 2021

Copy link
Copy Markdown
Contributor Author

Ok, might be good to add a legend {{pod}} on the first row panels.

It's added, but it's hidden because it could become too cluttered in big deployments. Similar to Tempo's operational dashboard which does the same (you can see where I took inspiration from :))

@mapno
mapno merged commit a1d1dfd into grafana-cold-storage:main Dec 17, 2021
@mapno
mapno deleted the tracing-mixin branch December 17, 2021 10:52
shamsalmon pushed a commit to shamsalmon/agent that referenced this pull request Feb 16, 2022
* Jsonnet lint

* Upgrade jsonnet libs

* Tracing pipeline dashboard

* Changelog

* Lint

* Lint

* Specify transport for receivers

* Add alerts

* Changelog

* Add grafana prefix

* Fix jsonnet formatting
@github-actions github-actions Bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Apr 7, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants